-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding HTTP service support for Envoy external processing #35489
Adding HTTP service support for Envoy external processing #35489
Conversation
Signed-off-by: Yanjun Xiang <[email protected]>
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
Signed-off-by: Yanjun Xiang <[email protected]>
Signed-off-by: Yanjun Xiang <[email protected]>
Signed-off-by: Yanjun Xiang <[email protected]>
Signed-off-by: Yanjun Xiang <[email protected]>
/assign @yanavlasov @rshriram |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM API modulo nit comment.
Signed-off-by: Yanjun Xiang <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thanks!
/retest |
…#35489) This is to address the 1st step, i.e, the API change needed for envoyproxy#35488. --------- Signed-off-by: Yanjun Xiang <[email protected]> Signed-off-by: Martin Duke <[email protected]>
…#35489) This is to address the 1st step, i.e, the API change needed for envoyproxy#35488. --------- Signed-off-by: Yanjun Xiang <[email protected]> Signed-off-by: asingh-g <[email protected]>
Risk Level: low
Testing: n/a
Docs Changes: n/a
Release Notes: inline
Fixes:
Description:
This is to address the 1st step, i.e, the API change needed for #35488.